Re: [PATCH] [media] davinci-vpfe: Fix retcode check
From: Dan Carpenter
Date: Tue Jul 08 2014 - 11:11:40 EST
On Tue, Jul 08, 2014 at 04:32:57PM +0200, Levente Kurusa wrote:
> 2014-07-08 16:08 GMT+02:00 Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>:
> > Use signed type to check correctly for negative error code. The issue
> > was reported with static analyser:
> > [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]:
> > (style) A pointer can not be negative so it is either pointless or an
> > error to check if it is.
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69071
> > Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
> Hmm, while it is true that get_ipipe_mode returns an int, but
> the consequent call to regw_ip takes an u32 as its second
> argument. Did it cause a build warning for you?
It won't cause a compile warning.
> (Can't really
> check since I don't have ARM cross compilers close-by)
Make a small test program and test.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/