Re: [PATCH] farsync: fix invalid memory accesses in fst_add_one() and fst_init_card()

[David Miller]

From: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Date: Sat,  5 Jul 2014 03:35:50 +0400

> -                }
> +			card->nports = i;
> +			return (card->nports == 0) ? err : 0;
> +		}

I don't think this is the right thing to do.

This will cause the caller to not free the IRQ or any of the
other resources.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/