Re: [PATCH] farsync: fix invalid memory accesses in fst_add_one() and fst_init_card()
From: Alexey Khoroshilov
Date: Tue Jul 08 2014 - 18:40:42 EST
On 08.07.2014 18:20, David Miller wrote:
> From: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> Date: Sat, 5 Jul 2014 03:35:50 +0400
>> - }
>> + card->nports = i;
>> + return (card->nports == 0) ? err : 0;
>> + }
> I don't think this is the right thing to do.
> This will cause the caller to not free the IRQ or any of the
> other resources.
My understanding of the existing code is to proceed if at least one port
So I return error code if no ports available at all, otherwise
initialization continues and can succeed.
If something else goes wrong, all resources are deallocated.
Do you suggest to return error code unconditionally?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/