Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

From: Linus Walleij
Date: Wed Jul 09 2014 - 05:43:09 EST

On Mon, Jul 7, 2014 at 5:11 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:

> This set of patches adds pin control drivers for Multi-purpose
> pin (MPP) and General-purpose pin (GPIO) controllers found
> in Qualcomm PMIC chips.
> MPP's are enhanced GPIO's with analog circuits, which support
> following functions in addition to digital input/output: analog
> input/output and current sinks.
> PMIC PM8941 have 8 MPP's and 36 GPIO's. PMIC PM8841 have 4 MPP's.
> Ivan T. Ivanov (4):
> pinctrl: qpnp: Qualcomm PMIC pin controller driver
> pinctrl: qcom: Add documentation for pinctrl-qpnp binding
> pinctrl: qcom: Add PM8941 and PM8941 pinctrl drivers
> ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes

Oh, I just spent some 45 minutes reviewing an 8xxx pinctrl driver from
BjÃrn Andersson
that *seems* to be doing exactly the same thing.

Now I have two drivers from people outside Qualcomm :-)

Some of my review comments on BjÃrn's driver (like using SI units with the pin
config) are actually adressed in this patch set. The idea to split in subdrivers
per-ASIC may be good? I don't really know.

Can you two guys *PLEASE* join efforts and combine your drivers into one?

If we do this efficiently it should be possible to get one single real
nice driver
in the end.

If you start arguing about nittt gritty stuff like who's going to be author on
the commit I'll get really disappointed ;-)

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at