Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

From: Ivan T. Ivanov
Date: Wed Jul 09 2014 - 07:13:34 EST


On Wed, 2014-07-09 at 11:43 +0200, Linus Walleij wrote:
> On Mon, Jul 7, 2014 at 5:11 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
> > This set of patches adds pin control drivers for Multi-purpose
> > pin (MPP) and General-purpose pin (GPIO) controllers found
> > in Qualcomm PMIC chips.
> >
> > MPP's are enhanced GPIO's with analog circuits, which support
> > following functions in addition to digital input/output: analog
> > input/output and current sinks.
> >
> > PMIC PM8941 have 8 MPP's and 36 GPIO's. PMIC PM8841 have 4 MPP's.
> >
> > Ivan T. Ivanov (4):
> > pinctrl: qpnp: Qualcomm PMIC pin controller driver
> > pinctrl: qcom: Add documentation for pinctrl-qpnp binding
> > pinctrl: qcom: Add PM8941 and PM8941 pinctrl drivers
> > ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes
> Oh, I just spent some 45 minutes reviewing an 8xxx pinctrl driver from
> BjÃrn Andersson
> that *seems* to be doing exactly the same thing.
> Now I have two drivers from people outside Qualcomm :-)
> Some of my review comments on BjÃrn's driver (like using SI units with the pin
> config) are actually adressed in this patch set. The idea to split in subdrivers
> per-ASIC may be good? I don't really know.
> Can you two guys *PLEASE* join efforts and combine your drivers into one?

Not sure. BjÃrn patches cover older PMIC chips, if not mistaken, mine
cover PMIC's used with APQ8074 and onward [1]. Main difference is
the bus which connects them to SoC, interrupts handling, runtime
pin type detection and register map.


[1] pm8019, pm8110, pm8226, pm8841, pm8916, pm8941, pm8994, pma8084,
pmd9635, pmd9635, pmi8962, pmi8994.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at