Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

From: Linus Walleij
Date: Wed Jul 09 2014 - 07:44:09 EST

On Wed, Jul 9, 2014 at 1:13 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
> On Wed, 2014-07-09 at 11:43 +0200, Linus Walleij wrote:
>> On Mon, Jul 7, 2014 at 5:11 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
>> > This set of patches adds pin control drivers for Multi-purpose
>> > pin (MPP) and General-purpose pin (GPIO) controllers found
>> > in Qualcomm PMIC chips.
>> >
>> > MPP's are enhanced GPIO's with analog circuits, which support
>> > following functions in addition to digital input/output: analog
>> > input/output and current sinks.
>> >
>> > PMIC PM8941 have 8 MPP's and 36 GPIO's. PMIC PM8841 have 4 MPP's.
>> >
>> > Ivan T. Ivanov (4):
>> > pinctrl: qpnp: Qualcomm PMIC pin controller driver
>> > pinctrl: qcom: Add documentation for pinctrl-qpnp binding
>> > pinctrl: qcom: Add PM8941 and PM8941 pinctrl drivers
>> > ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes
>> Oh, I just spent some 45 minutes reviewing an 8xxx pinctrl driver from
>> BjÃrn Andersson
>> that *seems* to be doing exactly the same thing.
>> Now I have two drivers from people outside Qualcomm :-)
>> Some of my review comments on BjÃrn's driver (like using SI units with the pin
>> config) are actually adressed in this patch set. The idea to split in subdrivers
>> per-ASIC may be good? I don't really know.
>> Can you two guys *PLEASE* join efforts and combine your drivers into one?
> Not sure. BjÃrn patches cover older PMIC chips, if not mistaken, mine
> cover PMIC's used with APQ8074 and onward [1]. Main difference is
> the bus which connects them to SoC, interrupts handling, runtime
> pin type detection and register map.

Oh OK... then atleast there is something wrong with the naming of
BjÃrns patches as they are 8xxx and your chips are also named
8xxx ...

Anyway I will create a patch to move the current msm driver down
to a folder named "qcom" and we can atleast collect these drivers
in a single place since the chipsets are related, OK?

Then I guess even if the chips are totally unrelated it'd be interesting
to have you two guys cross-review each other's drivers so the behaviour
is consistent across qualcomm platforms.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at