Re: [PATCH 4/6] x86-mce: Add spinlocks to prevent duplicated MCP and CMCI reports.

[Havard Skinnemoen]

On Wed, Jul 9, 2014 at 1:47 PM, Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>                 if (!(flags & MCP_UC) &&
> -                   (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
> +                   (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC))) {
> +                       spin_unlock_irqrestore(&mce_banks[i].poll_spinlock,
> +                                              irq_flags);
>                         continue;
> +               }
>
> Perhaps move this test for UC up to before you grab the lock?

Will do, thanks.

Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/