Re: [PATCH v6 4/5] PCI: add PCI controller for keystone PCIe h/w

[Murali Karicheri]

Rob,

On 07/18/2014 03:31 PM, Rob Herring wrote:
> On Fri, Jul 18, 2014 at 10:14 AM, Murali Karicheri<m-karicheri2@xxxxxx>  wrote:
--- Cut ---
> > +
> > +Optional properties:-
> > +       phys: phandle to Generic Keystone SerDes phy for PCI
> > +       phy-names: name of the Generic Keystine SerDes phy for PCI
> > +         - If boot loader already does PCI link establishment, then phys and
> > +           phy-names shouldn't be present.
> > +       ti,enable-linktrain - Enable Link training.
> > +         - If boot loader already does PCI link establishment, then this
> > +           shouldn't be present.
>
> Can't you read from the h/w if the link is trained?

Yes.

There are customers who use this driver with PCI Link setup done in the 
boot loader. This property tells the driver to bypass Link setup 
procedure in that case. Is this undesirable and if so. how other 
platforms handle it? Check first if link is trained or start the link 
setup procedure? Let me know. If this is fine, please provide your Ack.

Thanks.

Murali
> Rob

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/