Re: [PATCH v2] memory hotplug: update the variables after memory removed

[David Rientjes]

On Tue, 29 Jul 2014, Zhang Zhen wrote:

> >> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> >> index df1a992..fd7bd6b 100644
> >> --- a/arch/x86/mm/init_64.c
> >> +++ b/arch/x86/mm/init_64.c
> >> @@ -673,15 +673,11 @@ void __init paging_init(void)
> >>   * After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
> >>   * updating.
> >>   */
> >> -static void  update_end_of_memory_vars(u64 start, u64 size)
> >> +static void  update_end_of_memory_vars(u64 end_pfn)
> > 
> > Extra space that can be removed here at the same time as a cleanup.
> > 
> Sorry, where is the extra space here?
> 

There are two spaces between the function identifier and the function 
type whereas there is traditionally only one.  It existed before your 
patch, it would just be nice to clean it up since you're already touching 
the line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/