Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

[Dan Carpenter]

On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
> On 2014-07-28 at 09:58:12 +0200, Anil Belur <askb23@xxxxxxxxx> wrote:
> > From: Anil Belur <askb23@xxxxxxxxx>
> > 
> > - private_ioctl() the internally calls copy_{to,from}_user() and does
> >   not use '__user' while refrencing user space pointers.
> > - this patch passes __user annotation as a cast, when the pointer is
> >  being refernced.
> 
> Wouldn't it be better to annotate the data member in struct tagSCmdRequest
> with __user instead of introducing all these casts?

Don't ask rhetorical questions on email lists.  Just be blunt.

These casts are not the correct fix.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/