Re: [PATCH] spi: Fix warning about redefinition

From: Mark Brown
Date: Wed Aug 06 2014 - 13:56:52 EST


On Wed, Aug 06, 2014 at 12:55:28PM -0400, Nick Krause wrote:

> +#ifdef WRITE
> +#undef WRITE
> +#endif
> +#ifdef READ
> +#undef READ
> +#endif
> #define WRITE 0
> #define READ 1

Please think about what the effect of doing this is and look at how
other similar problems have been addressed - the goal isn't to shut up
the warning, it's to fix the problem the compiler is trying to tell you
about.

Attachment: signature.asc
Description: Digital signature