Re: [PATCH 8/8] x86: add comments about various syscall instructions, no code changes

From: Denys Vlasenko
Date: Fri Aug 08 2014 - 12:18:47 EST


On 08/05/2014 09:58 PM, Oleg Nesterov wrote:
> On 08/05, Denys Vlasenko wrote:
>>
>> This patch adds comments which explain in detail
>> what registers are modified by each of these instructions.
>> The comments are placed immediately before corresponding
>> entry and exit points.
>
> This is great ;)

I just discovered that I misunderstood how _exactly_
SYSCALL decides whether to save rflags to r11 or not.

(Wrote an actual testcase for 32bit -> 64bit SYSCALL
transition. Practice always trumps theory, doesn't it? ;)

So I had to fix my comments in this patch. I guess
I need to send v4 of the patchset now...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/