Re: [RFC PATCH 1/5] proc: intoduce proc_inode->pid_entry and is_tgid_pid_entry()

From: Cyrill Gorcunov
Date: Sun Aug 10 2014 - 03:16:27 EST


On Sat, Aug 09, 2014 at 04:28:50PM +0200, Oleg Nesterov wrote:
> >
> > Hi Oleg, sorry for not responding to previous emails, will try to review this
> > things tomorrow (from a glance looks quite good!). Btw, this moment strike my
> > eyes -- why don't we use kmem_cache_zalloc here but do assign nils again and
> > again, maybe worth to address as well?
>
> Probably because this doesn't make sense to nullify proc_inode->vfs_inode,
> it will be reinitialized at least by inode_init_always() anyway.

Yeah, thanks. I managed to fogeth that we call inode_init_always after inode
get allocated. As to series -- looks like a good start, and I think Eric
is a way more confident in this area than me so i've nothing to add up
to his comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/