Re: [PATCH 05/33] perf record: Allow the user to disable time stamps

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Tue, Aug 12, 2014 at 04:58:19PM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > Em Tue, Aug 05, 2014 at 08:08:56AM +0200, Ingo Molnar escreveu:
> > > > This patch looks dangerous and misleading to me.
> 
> > > I took it more from the angle: hey, it fixes a regression, i.e. 
> > > -T/--time somehow became a noop, and also it doesn't change any 
> > > default.
> 
> > > It also states that you will get misaccounting, why that would 
> > > happen, althought wording could've been better, as mmaps won't be 
> > > "missing", i.e. they will be there as this governs just 
> > > PERF_SAMPLE_TIME, not perf_event_attr.mmap, so it MMAPs may come 
> > > after samples for its maps.
> 
> > > So, I took it.
> 
> > > How should we proceed?
> 
> > I'd be fine with applying the patch and fixing the misleading 
> > changelog.
> 
> Done:
> 
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=8affc2b8c27bfc2d6e70827b746f490b62c44eaa
> 
> Consider now pulling the perf-core-for-mingo tag there, I updated it
> after updating the changelog for this specific commit, all the
> rest is the same as in the previous pull req.

Pulled into tip:perf/core, thanks a lot Arnaldo!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/