Re: [GIT PULL] Detaching mounts on unlink for 3.15

From: Al Viro
Date: Wed Aug 13 2014 - 09:18:44 EST


On Tue, Aug 12, 2014 at 03:17:10AM -0700, Eric W. Biederman wrote:
> I have rebased my changes against vfs.git#for-eric and my changes work
> just fine on top of the base you have built. The changes are avaiable
> in user-namespace.git#vfs-detach-mounts10 so you just be able to just
> pull the changes in.
>
> Reading your pile #1 pull request to Linus it sounds like you are
> planning to suck all of this into the vfs tree.

I am. Questions:
* is there any reason why we need list instead of hlist for
per-mountpoint list of mounts? Looks like hlist would do just as
well, and it's a bit less noise
* __d_unalias() change looks rather odd. What we do there
is _not_ "avoid leaking mounts", it's "don't get a bunch of existing
mounts suddenly relocate". What's up with that one?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/