Re: [PATCH] module: Clean up ro/nx after early module load failures

From: Rusty Russell
Date: Fri Aug 15 2014 - 15:24:47 EST


Andy Lutomirski <luto@xxxxxxxxxxxxxx> writes:
> The commit
>
> 4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>
> introduced a regression: if a module fails to parse its arguments or
> if mod_sysfs_setup fails, then the module's memory will be freed
> while still read-only. Anything that reuses that memory will crash
> as soon as it tries to write to it.

Thanks, good catch.

Applied,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/