Re: [PATCH] module: Clean up ro/nx after early module load failures

[Andy Lutomirski]

On Fri, Aug 15, 2014 at 11:49 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> Andy Lutomirski <luto@xxxxxxxxxxxxxx> writes:
>> The commit
>>
>>     4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>>
>> introduced a regression: if a module fails to parse its arguments or
>> if mod_sysfs_setup fails, then the module's memory will be freed
>> while still read-only.  Anything that reuses that memory will crash
>> as soon as it tries to write to it.
>
> Thanks, good catch.

Catching it was easy.  Figuring out wtf was happening to my poor
computer, on the other hand... :)

>
> Applied,
> Rusty.



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/