Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string

[Takashi Iwai]

At Tue, 26 Aug 2014 17:52:14 +0530,
Sudip Mukherjee wrote:
> 
> fixed broken user visible strings

This text just repeats what the summary line says.  Instead, you
should write *why* the patch is needed.  Ditto for the previous
patch.

> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
> 
> I am not exactly sure about the patch as some lines after fixing has crossed the limit of 80 characters.
> But the coding style says :
> "never break user-visible strings such as printk messages, because that breaks the ability to grep for them"

Right, the 80 chars rule can be a guideline, it doesn't always force
the codes to fit within.  A long message string is clearly such a
case.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/