Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

From: Mark Brown
Date: Tue Sep 09 2014 - 11:22:20 EST


On Tue, Sep 09, 2014 at 08:17:51AM -0500, Timur Tabi wrote:
> Shengjiu Wang wrote:
> >+ if (ssi_private->soc->imx)
> >+ clk_prepare_enable(ssi_private->clk);

> How about this instead?

> if (ssi_private->clk)
> clk_prepare_enable(ssi_private->clk);

Should be a !IS_ERR() - NULL is a valid clock.

Attachment: signature.asc
Description: Digital signature