Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

[Timur Tabi]

On 09/09/2014 10:21 AM, Mark Brown wrote:
> > if (ssi_private->clk)
> > >	clk_prepare_enable(ssi_private->clk);

> Should be a !IS_ERR() - NULL is a valid clock.

In that case, ssi_private->clk needs to be initialized to -EINVAL or 
something, so that the check works on systems that don't have any clocks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/