Re: [RFC PATCH 8/8] Revert "percpu: free percpu allocation info for uniprocessor system"

From: Guenter Roeck
Date: Sun Sep 21 2014 - 14:38:22 EST


On 09/21/2014 10:23 AM, Mikael Starvik wrote:
Thanks for all your work with CRIS! CRISv10 is alive but is currently used as small helper CPUs close to hardware blocks.


You are welcome. Now it would be even better if we could get the upstream code to work
with qemu. Which leads to the questions - is CRISv32 alive, and is there a chance
to get there ? Also, if CRISv10 is alive, is there any interest or even benefit to
maintain it in the latest kernel ? Because if not, we might as well drop v10 support
to simplify kernel maintenance.

Thanks,
Guenter

Jesper will review and ack.

21 sep 2014 kl. 18:27 skrev "Guenter Roeck" <linux@xxxxxxxxxxxx>:

This reverts commit 3189eddbcafcc4d827f7f19facbeddec4424eba8.

The commit causes a hang with a crisv32 image. This may be an architecture
problem, but at least for now the revert is necessary to be able to boot a
crisv32 image.

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
mm/percpu.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/mm/percpu.c b/mm/percpu.c
index da997f9..2139e30 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1932,8 +1932,6 @@ void __init setup_per_cpu_areas(void)

if (pcpu_setup_first_chunk(ai, fc) < 0)
panic("Failed to initialize percpu areas.");
-
- pcpu_free_alloc_info(ai);
}

#endif /* CONFIG_SMP */
--
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/