Re: [PATCH] vfs: Don't exchange filenames unconditionally.
From: Miklos Szeredi
Date: Tue Sep 23 2014 - 12:20:25 EST
On Fri, Sep 19, 2014 at 4:22 PM, Mikhail Efremov <sem@xxxxxxxxxxx> wrote:
> On Thu, 18 Sep 2014 13:22:07 +0200 Mateusz Guzik wrote:
>> On Thu, Sep 18, 2014 at 02:55:00PM +0400, Mikhail Efremov wrote:
>> > Only exchange source and destination filenames
>> > if flags contain RENAME_EXCHANGE.
Acked-by: Miklos Szeredi <mszeredi@xxxxxxx>
>> But names are still exchanged without RENAME_EXCHANGE, provided they are
>> long enough.
>> da1ce0670c14 introduced this behaviour also for short names and this is
>> what you are reverting here.
>> That said, I think the patch is fine as an interim change, but should
>> note facts mentioned above.
>> For more info please see https://lkml.org/lkml/2014/9/7/6
> Thanks for pointing out that thread to me, I didn't read it before
> sending the patch.
>> I'll be posting a RFC patch for actual problem next week.
> I suppose then that no sense to resend this patch right now, I'll just
> wait the proper solution from you.
> Yet this patch can be used as a temporary workaround (as you mentioned
> above) if the proper solution takes longer than expected to implement.
Yes, feel free to resend it to Linus, before 3.17 proper is out.
Also please consider adding:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/