Re: [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch

From: Valdis . Kletnieks
Date: Tue Sep 23 2014 - 12:20:45 EST


On Tue, 23 Sep 2014 13:28:48 +0200, Michal Hocko said:
> And there is another one hitting during randconfig. The patch makes my
> eyes bleed

Amen. But I'm not seeing a better fix either.

> #if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> - "tlb_flush_pending %d\n",
> + "tlb_flush_pending %d\n"
> #endif
> - mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
> + , mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,

I'm surprised that checkpatch doesn't explode on this. And I'm starting
a pool on how soon somebody submits a patch to "fix" this. :)

Attachment: pgpPILq2BK7Ih.pgp
Description: PGP signature