Re: [PATCH v2] vfs: Don't exchange "short" filenames unconditionally.

From: Linus Torvalds
Date: Mon Sep 29 2014 - 16:45:11 EST

On Mon, Sep 29, 2014 at 12:04 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>> "dname_external()".
> That we do... Why is it in dcache.h, BTW? No users outside of fs/dcache.c
> and I can't imagine a valid use for it in a module, let alone out-of-tree
> one...

Yeah, no, remove the declaration in dcache.h, and make it static to
fs/dcache.c. I don't think there's any possible valid use outside of

> ObAnnoyance: gcc not figuring out that this container_of() isn't going to be
> NULL... Sure, somebody might put (char *)16 into dentry->, but...
> As it is, it makes for messier code generation; I can work around that, of
> course, but it's uglier than it ought to be ;-/

You could possibly play games with __attribute__((nonnull)) or
whatever it's called. Although I think you can only annotate arguments
that way (and you do it not by annotating the argument, but by making
it a function attribute, which I think is horrible, but whatever).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at