Re: [PATCH v2 2/4] regulator: Set ena_gpio_initialized in regulator drivers

[Mark Brown]

On Wed, Oct 08, 2014 at 03:47:06PM +0200, Markus Pargmann wrote:

> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -225,6 +225,8 @@ static int max8952_pmic_probe(struct i2c_client *client,
>  	config.of_node = client->dev.of_node;
>  
>  	config.ena_gpio = pdata->gpio_en;
> +	if (!pdata)
> +		config.ena_gpio_initialized = true;

This looks wrong, we're checking for pdata being non-NULL immediately
after dereferencing pdata.

Attachment: signature.asc
Description: Digital signature