Re: [PATCH] audio: sai: Add Power Management support

From: Mark Brown
Date: Thu Oct 30 2014 - 07:23:27 EST


On Thu, Oct 30, 2014 at 03:30:40AM +0000, Li.Xiubo@xxxxxxxxxxxxx wrote:

> One more thing, if the device is not performance critical, then shouldn't we
> Take care of the cache memory consumption to determine using flat or rbtree
> Type ?

Yes, it's always fine to use a rbtree if it makes sense - it was just an
unusual choice for a device like this that didn't seem to be discussed.

Depending on the register map a flat cache can actually be more memory
efficient sometimes since there's some overhead for the rbtree data
structures, if you've just got one block of registers with no gaps a
flat cache is going to be a win there.

Attachment: signature.asc
Description: Digital signature