Re: [GIT PULL] ext4 bug fixes for 3.18

From: Linus Torvalds
Date: Fri Oct 31 2014 - 19:26:21 EST


On Fri, Oct 31, 2014 at 2:49 PM, Theodore Ts'o <tytso@xxxxxxx> wrote:
>
> Theodore Ts'o (1):
> jbd2: use a better hash function for the revoke table

Does it really make sense to use hash_u64()? It can be quite expensive
(mainly on 32-bit targets), and since the low bits are where all the
information is anyway, I'd suggest using hash_32() here even if the
block number in theory can have a few bits above the 32-bit mark.

Anyway, pulled, but I just reacted to that small detail.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/