Re: [PATCH] printk: drop logbuf_cpu volatile qualifier

[Alex Elder]

On 11/14/2014 01:45 PM, Steven Rostedt wrote:
> On Fri, 14 Nov 2014 13:19:31 -0600
> Alex Elder <elder@xxxxxxxxxx> wrote:
> 
>> Pranith Kumar posted a patch in which removed the "volatile"
>> qualifier for the "logbuf_cpu" variable in vprintk_emit().
>>     https://lkml.org/lkml/2014/11/13/894
>> In his patch, he used ACCESS_ONCE() for all references to
>> that symbol to provide whatever protection was intended.
>>
>> There was some discussion that followed, and in the end
>> Stephen Rostedt concluded that not only was "volatile" not
> 
> I don't know of a Stephen Rostedt. J

Sorry.  I'm sure that's a source of annoyance.  -Alex

>> needed, neither was it required to use ACCESS_ONCE().  I
>> offered an elaborate description that concluded Stephen
> 
> Who is this Stephen you talk about?

. . .

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/