Re: [patch 09/16] genirq: Add generic msi irq domain support

[Thomas Gleixner]

On Tue, 18 Nov 2014, Yun Wu (Abel) wrote:
> On 2014/11/18 20:49, Jiang Liu wrote:
> >>> +	ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
> >>> +	if (ret < 0)
> >>> +		return ret;
> >>> +
> >>> +	for (i = 0; i < nr_irqs; i++) {
> >>> +		ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg);
> >>> +		if (ret < 0) {
> >>> +			if (ops->msi_free) {
> >>> +				for (i--; i > 0; i--)
> >>
> >> while (i--) ?

The allocation for 'i' failed. So we don't free i. You missed the real
bug here:

> >>> +				for (i--; i > 0; i--)

Must be i >= 0.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/