Re: [PATCH 13/26 v5] tracing: Fix return value of ftrace_raw_output_prep()

[Petr Mladek]

On Fri 2014-11-14 23:59:00, Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx>
> 
> If the trace_seq of ftrace_raw_output_prep() is full this function
> returns TRACE_TYPE_PARTIAL_LINE, otherwise it returns zero.
> 
> The problem is that TRACE_TYPE_PARTIAL_LINE happens to be zero!
> 
> The thing is, the caller of ftrace_raw_output_prep() expects a
> success to be zero. Change that to expect it to be
> TRACE_TYPE_HANDLED.
> 
> Link: http://lkml.kernel.org/r/20141114112522.GA2988@xxxxxxxxxxxxxxx
> 
> Reminded-by: Petr Mladek <pmladek@xxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxx>

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/