Re: [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips

[Soeren Moch]

On 19.11.2014 04:18, Shawn Guo wrote:
> On Wed, Nov 12, 2014 at 04:20:37PM +0800, Robin Gong wrote:
>> All chips of i.mx6 can be powered off by programming SNVS.
>> For example :
>> On i.mx6q-sabresd board, PMIC_ON_REQ connect with external
>> pmic ON/OFF pin, that will cause the whole PMIC powered off
>> except VSNVS. And system can restart once PMIC_ON_REQ goes
>> high by push POWRER key.
>>
>> Signed-off-by: Robin Gong <b38343@xxxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    4 ++++
>>  arch/arm/boot/dts/imx6qdl.dtsi         |    6 ++++++
>>  arch/arm/boot/dts/imx6sl-evk.dts       |    4 ++++
>>  arch/arm/boot/dts/imx6sl.dtsi          |    6 ++++++
>>  arch/arm/boot/dts/imx6sx-sdb.dts       |    4 ++++
>>  arch/arm/boot/dts/imx6sx.dtsi          |    6 ++++++
>>  6 files changed, 30 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> index 07fb302..ba12cc6 100644
>> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> @@ -531,6 +531,10 @@
>>  	status = "okay";
>>  };
>>  
>> +&snvs-poweroff {
>> +	status = "okay";
>> +};"
>> +
>>  &ssi2 {
>>  	status = "okay";
>>  };
>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
>> index c701af9..3a032d1 100644
>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> @@ -645,6 +645,12 @@
>>  					interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
>>  						     <0 20 IRQ_TYPE_LEVEL_HIGH>;
>>  				};
>> +
>> +				snvs-poweroff: snvs-poweroff@38 {
> 
> I'm not sure if it's because my DTC version is too low or you didn't
> test, the DTC reports error in label name 'snvs-poweroff'.  IIRC, hyphen
> '-' cannot be used in label name, but underscore '_' can.
> 
> Shawn

In the patch series "[PATCH v4 0/3] add power off driver for i.mx6" from
Sep 26 (what I have tested) snvs_poweroff was used. This worked as expected.

So this series "[PATCH v4 0/3] add power off driver for i.mx6" (sent on
Nov 12) apparently contains old patches and is not simply resent as
stated in the cover letter.

Soeren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/