Re: [PATCH V4] arm64: amd-seattle: Adding device tree for AMD Seattle platform

[Suthikulpanit, Suravee]

On 11/25/14, 18:57, "Arnd Bergmann" <arnd@xxxxxxxx> wrote:

>On Monday 24 November 2014 15:51:17 suravee.suthikulpanit@xxxxxxx wrote:
>> 
>> +	gic: interrupt-controller@e1101000 {
>> +		compatible = "arm,gic-400", "arm,cortex-a15-gic";
>> +		interrupt-controller;
>> +		#interrupt-cells = <3>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		reg = <0x0 0xe1110000 0 0x1000>,
>> +		      <0x0 0xe112f000 0 0x2000>,
>> +		      <0x0 0xe1140000 0 0x10000>,
>> +		      <0x0 0xe1160000 0 0x10000>;
>> +		interrupts = <1 9 0xf04>;
>> +		ranges;
>> +		v2m0: v2m@e1180000 {
>> +			compatible = "arm,gic-v2m-frame";
>> +			msi-controller;
>> +			arm,msi-base-spi = <64>;
>> +			arm,msi-num-spis = <256>;
>> +			reg = <0x0 0xe1180000 0 0x1000>;
>> +		};
>> +	};
>
>
>Having an empty ranges property in the gic seems strange, especially
>since the registers of the v2m seem to directly follow the gic's own
>registers. Could you limit the ranges to only the registers that
>are in the gic or its child devices itself?
>
>	Arnd

Yes, I can change it to ranges = <0 0 0 0xe1100000 0 0x100000> to limit
the range to just the GIC address range.

Thanks,

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/