Re: [PATCH] ext4: fix suboptimal seek_{data,hole} extents traversial

From: Theodore Ts'o
Date: Sat Nov 29 2014 - 12:53:07 EST


On Fri, Nov 28, 2014 at 06:02:02PM +0300, Dmitry Monakhov wrote:
> FYI: inline_data feature is fatally broken

Thanks for finding the bugs!

> 2) ext4_inline_data_fiemap(0 ignores start and len arguments from ext4_filemap()
> which obviously result in endless loop for anyone who want to use
> fiemap for inline files (which my patch try to do)

Would this have been triggered using filefrag? I just checked and
noticed we don't have a filefrag test in xfstests; of course it would
be impossible to test other than the filefrag -v command successfully
completed, but maybe it might be worth adding such a test.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/