Re: [PATCH] staging: comedi: change some printk calls to pr_err

[Ian Abbott]

On 01/12/14 08:47, Jeremiah Mahler wrote:
> Chase,
>
> On Sun, Nov 30, 2014 at 11:05:56PM -0600, Chase Southwood wrote:
> > There are a handful of calls to printk in ni_stc.h without specified log
> > levels, as well as one in ni_mio_common.c.  This patch converts these
> > calls to pr_err() instead, so that they are now explicitly log level
> > ERR.
> >
> > Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx>
> > ---
> > I tacked the change to ni_mio_common.c on to this patch since it's the same
> > exact change and it's just one line, so I think a single patch is justified
> > here.
> >   drivers/staging/comedi/drivers/ni_mio_common.c |  2 +-
> >   drivers/staging/comedi/drivers/ni_stc.h        | 14 +++++++-------
> >   2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> > index 353c17b..11e7017 100644
> > --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> > @@ -3945,7 +3945,7 @@ static unsigned ni_gpct_to_stc_register(enum ni_gpct_register reg)
> >   		stc_register = Interrupt_B_Enable_Register;
> >   		break;
> >   	default:
> > -		printk("%s: unhandled register 0x%x in switch.\n",
> > +		pr_err("%s: unhandled register 0x%x in switch.\n",
> >   		       __func__, reg);
> >   		BUG();
> >   		return 0;
> [...]
>
> On my system the default log level is 4 which corresponds to
> KERN_WARNING.  So switching to pr_err() would change the log level
> of these messages.  Using pr_warn() might be a better choice.

I wouldn't worry about the log level in this case as those printks would 
only be reached due to driver bugs.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/