Re: [PATCH 2/7] KVM: arm: guest debug, define API headers

[Alex BennÃe]

Christoffer Dall <christoffer.dall@xxxxxxxxxx> writes:

> On Wed, Nov 26, 2014 at 03:04:10PM +0000, Alex BennÃe wrote:
>> 
>> Peter Maydell <peter.maydell@xxxxxxxxxx> writes:
>> 
>> > On 25 November 2014 at 16:10, Alex BennÃe <alex.bennee@xxxxxxxxxx> wrote:
>> >> +/* Exit types which define why we did a debug exit */
>> >> +#define KVM_DEBUG_EXIT_ERROR           0x0
>> >> +#define KVM_DEBUG_EXIT_SINGLE_STEP     0x1
>> >> +#define KVM_DEBUG_EXIT_SW_BKPT         0x2
>> >> +#define KVM_DEBUG_EXIT_HW_BKPT         0x3
>> >> +#define KVM_DEBUG_EXIT_HW_WTPT         0x4
>> >
>> > The names of these imply that they're generic, but they're
>> > defined in an arch-specific header file...
>> 
>> Yeah, I think these will die and I'll just export the syndrome
>> information directly to QEMU.
>
> huh?

Rather than mapping syndrome to a specific exit value we might as well
export syndrome information to QEMU and let it define the reason.


>
> -Christoffer

-- 
Alex BennÃe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/