Re: [PATCH/RFC v8 12/14] leds: Add driver for AAT1290 current regulator

[Jacek Anaszewski]

Hi Pavel,

Thanks for a review.

On 11/29/2014 08:05 PM, Pavel Machek wrote:
> Hi!
>
>
> > @@ -0,0 +1,472 @@
> > +/*
> > + *	LED Flash class driver for the AAT1290
> > + *	1.5A Step-Up Current Regulator for Flash LEDs
> > + *
> > + *	Copyright (C) 2014, Samsung Electronics Co., Ltd.
> > + *	Author: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * version 2 as published by the Free Software Foundation.
> > + */
> > +
>
> > +#define AAT1290_MM_TO_FL_1_92	1
> > +#define AAT1290_MM_TO_FL_3_7	2
> > +#define AAT1290_MM_TO_FL_5_5	3
> > +#define AAT1290_MM_TO_FL_7_3	4
> > +#define AAT1290_MM_TO_FL_9	5
> > +#define AAT1290_MM_TO_FL_10_7	6
> > +#define AAT1290_MM_TO_FL_12_4	7
> > +#define AAT1290_MM_TO_FL_14	8
> > +#define AAT1290_MM_TO_FL_15_9	9
> > +#define AAT1290_MM_TO_FL_17_5	10
> > +#define AAT1290_MM_TO_FL_19_1	11
> > +#define AAT1290_MM_TO_FL_20_8	12
> > +#define AAT1290_MM_TO_FL_22_4	13
> > +#define AAT1290_MM_TO_FL_24	14
> > +#define AAT1290_MM_TO_FL_25_6	15
> > +#define AAT1290_MM_TO_FL_OFF	16
>
> Only one of these defines is unused.

The only cost of these macros are lines of code and I think
it is worth of having all the possible settings listed in one place.

> > +static struct of_device_id aat1290_led_dt_match[] = {
>
> > +	{.compatible = "skyworks,aat1290"},
>
> spaces after { and before } ?

I see both styles in kernel, but ok, I will add spaces.

Regards,
Jacek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/