Re: [PATCH v4 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc

[Zhou Wang]

On 2014å12æ01æ 17:25, Brian Norris wrote:
> I forgot to mention these comments:
>
> On Tue, Nov 04, 2014 at 08:47:00PM +0800, Zhou Wang wrote:
> > +static int hisi_nfc_remove(struct platform_device *pdev)
> > +{
> > +	struct hinfc_host *host = platform_get_drvdata(pdev);
> > +	struct mtd_info *mtd = &host->mtd;
> > +
> > +	nand_release(mtd);
> > +	dma_free_coherent(&pdev->dev, mtd->writesize + mtd->oobsize,
> > +			  host->buffer, host->dma_buffer);
> > +
> > +	return 0;
> > +}
> > +
> > +#ifdef CONFIG_PM_SLEEP
> > +static int hisi_nfc_suspend(struct platform_device *pdev,
> > +			       pm_message_t state)
>
> This is the wrong prototype. See struct dev_pm_ops.

My mistake here, will modify this, thanks a lot!!

> > +{
> > +	struct hinfc_host *host = platform_get_drvdata(pdev);
> > +
> > +	while ((hinfc_read(host, HINFC504_STATUS) & 0x1) == 0x0)
> > +		;
> > +
> > +	while ((hinfc_read(host, HINFC504_DMA_CTRL))
> > +		& HINFC504_DMA_CTRL_DMA_START)
> > +		_cond_resched();
> > +
> > +	return 0;
> > +}
> > +
> > +static int hisi_nfc_resume(struct platform_device *pdev)
>
> Same here.
>
> > +{
> > +	int cs;
> > +	struct hinfc_host *host = platform_get_drvdata(pdev);
> > +	struct nand_chip *chip = &host->chip;
> > +
> > +	for (cs = 0; cs < chip->numchips; cs++)
> > +		hisi_nfc_send_cmd_reset(host, cs);
> > +	hinfc_write(host, SET_HINFC504_PWIDTH(HINFC504_W_LATCH,
> > +		    HINFC504_R_LATCH, HINFC504_RW_LATCH), HINFC504_PWIDTH);
> > +
> > +	return 0;
> > +}
> > +#endif
> > +static SIMPLE_DEV_PM_OPS(hisi_nfc_pm_ops, hisi_nfc_suspend, hisi_nfc_resume);
>
> Brian

Thanks,
Zhou Wang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/