Re: [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent

[Joerg Roedel]

On Mon, Dec 01, 2014 at 03:28:03PM -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 28, 2014 at 12:29:07PM +0100, Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@xxxxxxx>
> > 
> > Print a warning when all allocation tries have been failed
> > and the function is about to return NULL. This prepares for
> > calling the function with __GFP_NOWARN to suppress
> > allocation failure warnings before all fall-backs have
> > failed.
> 
> This can be quite noisy. Especially the dump-stack.

Well, this is as noisy as the dump_stack()s from the page-allocator when
the first allocation try fails. The goal of the first two patches in
this series is to only print a warning (with stack-trace) when
alloc_coherent failed, and not when only an intermediate step failed
that has a fall-back anyway (and might thus be no real problem).


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/