Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

From: Andy Yan
Date: Wed Dec 03 2014 - 06:59:49 EST



On 2014å12æ03æ 19:52, Philipp Zabel wrote:
Am Mittwoch, den 03.12.2014, 17:46 +0800 schrieb Andy Yan:
On 2014å12æ03æ 02:23, Philipp Zabel wrote:
Hi Andy,

Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan:
diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
new file mode 100644
index 0000000..107c1ca
--- /dev/null
+++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
@@ -0,0 +1,40 @@
+DesignWare HDMI bridge bindings
+
+Required properities:
+- compatible: platform specific such as:
+ * "fsl,imx6q-hdmi"
+ * "fsl,imx6dl-hdmi"
+ * "rockchip,rk3288-dw-hdmi"
I think we should add a common compatible value "snps,dw-hdmi-tx" here:

compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx";

+- reg: Physical base address and length of the controller's registers.
+- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
Better make ddc-i2c-bus optional, see the other thread about the ddc i2c
master.
I have the same idea too, but the patch about ddc i2c master has not
landed yet, can we change the ddc-i2c-bus to optional after the ddc
i2c master
patch land?
Check out Documentation/devicetree/bindings/drm/imx/hdmi.txt, it was
already marked as optional. We can't make it required now.

regards
Philipp



OK, got it, thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/