Re: [PATCH] KVM: cpuid: mask more bits in leaf 0xd and subleaves

[Paolo Bonzini]

On 03/12/2014 13:07, Radim KrÄmÃÅ wrote:
>> > Well, there is a WARN just above. :)  But I can change it to zero instead.
> Yeah, I wasn't sure about the WARN ... I can only see it trigger after
> host xcr0 changes and we are much more screwed in that case anyway :)
> (But it has a chance of catching a bug, so it isn't only bad.)
> 
> The guest expects 0 here, so I'd rather have it ...

Ok, I'll have

		if (WARN_ON_ONCE(entry[i].ecx & 1))
			continue;
	}
	entry[i].ecx = 0;
	entry[i].edx = 0;
	...

Thanks for the review!

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/