Re: ALSA: ctxfi: Delete an unnecessary check before kfree()

From: Takashi Iwai
Date: Wed Dec 03 2014 - 07:42:05 EST


At Wed, 03 Dec 2014 12:38:51 +0100,
SF Markus Elfring wrote:
>
> >> Deletion of an unnecessary check before the function call "kfree"
> >> One function call less in get_daio_rsc() after error detection
> >
> > In these cases, the changes aren't so straightforward, and they don't
> > improve the readability.
>
> How do you prefer to improve the affected source code here?

Don't touch then. There are no bugs to fix there.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/