Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

[Andy Yan]

On 2014å12æ04æ 00:11, Russell King - ARM Linux wrote:
> On Thu, Dec 04, 2014 at 12:04:37AM +0800, Andy Yan wrote:
> > Hi Russell:
> >
> > On 2014å12æ03æ 23:38, Russell King - ARM Linux wrote:
> > > On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote:
> > > > +int imx_hdmi_bind(struct device *dev, struct device *master,
> > > > +		  void *data, struct drm_encoder *encoder,
> > > > +		  const struct imx_hdmi_plat_data *plat_data)
> > > >   {
> > > >   	struct platform_device *pdev = to_platform_device(dev);
> > > > -	const struct of_device_id *of_id =
> > > > -				of_match_device(imx_hdmi_dt_ids, dev);
> > > >   	struct drm_device *drm = data;
> > > >   	struct device_node *np = dev->of_node;
> > > >   	struct device_node *ddc_node;
> > > > @@ -1594,19 +1566,16 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
> > > >   	struct resource *iores;
> > > >   	int ret, irq;
> > > > -	hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
> > > > +	hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
> > > >   	if (!hdmi)
> > > >   		return -ENOMEM;
> > > > -	hdmi->dev = dev;
> > > > +	hdmi->plat_data = plat_data;
> > > > +	hdmi->dev = &pdev->dev;
> > > > +	hdmi->dev_type = plat_data->dev_type;
> > > >   	hdmi->sample_rate = 48000;
> > > >   	hdmi->ratio = 100;
> > > > -
> > > > -	if (of_id) {
> > > > -		const struct platform_device_id *device_id = of_id->data;
> > > > -
> > > > -		hdmi->dev_type = device_id->driver_data;
> > > > -	}
> > > > +	hdmi->encoder = encoder;
> > > I'd suggest changing imx_hdmi_bind() to take the struct resource and irq
> > > number, and avoiding the platform device stuff altogether in here.
> >     Actually this is what the current code do: the resource and irq number
> > are all handled in imx_hdmi_bind
> I meant that imx_hdmi_bind should be passed these, so that it needs to
> know nothing about the struct device beyond the generic device structure.
> In other words, the dw-hdmi core should not assume that the struct device
> is part of a platform device.
   if so, how about the device tree properties  ddc-i2c-bus, 
reg-io-width, iahb, isfr,
  they are all found by device?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/