Re: [PATCH v12 01/19] input: cyapa: modify code to following kernel code style

From: Jeremiah Mahler
Date: Wed Dec 03 2014 - 23:57:44 EST


Dudley,

On Wed, Dec 03, 2014 at 05:30:07PM +0800, Dudley Du wrote:
> This patch modified the code to fix the patch check warning issue with latest
> checkpatch.sh tool, and also changed the return variable name from "ret" to
> "error" when there is only one error path to follow code style.
> TEST=test on Chromebooks.
>
> Signed-off-by: Dudley Du <dudley.dulixin@xxxxxxxxx>
> ---
> drivers/input/mouse/cyapa.c | 162 ++++++++++++++++++++++----------------------
> 1 file changed, 80 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index b409c3d..c9fdf6d 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
[...]

I was hoping to test out your patchset since the patch for the touchpad
problem [1] still has not appeared in linux-next as of 20141203.
Unfortunately your patchset does not apply so I can't test it. Which
kernel is your work based off of?

[1]: https://lkml.org/lkml/2014/11/27/684

--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/