Re: [PATCH] sched/fair: fix select_task_rq_fair return -1

[Vincent Guittot]

On 4 December 2014 at 12:10, Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx> wrote:
>>
>> The change below  will give a similar behavior than 3.18 for 3.14 and
>> we still match the condition if (new_cpu == -1 || new_cpu == cpu) in
>>
> And -1 is no longer needed.

yes indeed

>
>> order to go in the child level
>>
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -4151,7 +4151,7 @@ static int
>>  find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu)
>>  {
>>         unsigned long load, min_load = ULONG_MAX;
>> -       int idlest = -1;
>> +       int idlest = this_cpu;
>>         int i;
>>
>>         /* Traverse only the allowed CPUs */
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/