RE: [PATCH v2] sched/fair: fix find_idlest_cpu return -1

[Liu, Chuansheng]

> -----Original Message-----
> From: Vincent Guittot [mailto:vincent.guittot@xxxxxxxxxx]
> Sent: Thursday, December 04, 2014 8:15 PM
> To: Zhang, Jun
> Cc: mingo@xxxxxxxxxx; Peter Zijlstra; gregkh@xxxxxxxxxxxxxxxxxxx; Hillf
> Danton; linux-kernel; stable@xxxxxxxxxxxxxxx; Liu, Chuansheng; Liu,
> Changcheng
> Subject: Re: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
> 
> On 4 December 2014 at 12:43,  <jun.zhang@xxxxxxxxx> wrote:
> > From: zhang jun <jun.zhang@xxxxxxxxx>
> >
> > in function select_task_rq_fair, when find_idlest_cpu return -1 and sd->child
> == NULL
> > select_task_rq_fair return -1, system panic.
> 
> you forgot to add on which kernel version this patch applies.
> 
> We don't have such issue on 3.18-rc7 as find_idlest_cpu don't return
> -1. We only need a cleanup of the test against -1 for 3.18-rc
> 
Agreed, so Jun can make two patches:
The first one patch is in find_idlest_cpu() to not return -1 and based on stable-branch such as 3.14.x;
The second patch is one cleanup for new_cpu == -1 judgment against the 3.18-rc, since it is no possibility now;

Best Regards
Chuansheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/