Re: [PATCH] tinification: Make SRCU optional by using CONFIG_SRCU

[Josh Triplett]

On Thu, Dec 04, 2014 at 10:30:20PM -0500, Pranith Kumar wrote:
> On Thu, Dec 4, 2014 at 9:05 PM, Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:
> > On 12/05/2014 08:11 AM, Paul E. McKenney wrote:
> >> On Thu, Dec 04, 2014 at 06:50:24PM -0500, Pranith Kumar wrote:
> >>>
> >>> +config SRCU
> >>> +    bool "Sleepable form of RCU"
> >
> > Why it has a title? Somebody need to select it manually for third party kernel module?
> 
> Yes, it is a choice given to enable SRCU even when no in-kernel module uses it.

That makes sense for testing purposes, but I don't think it makes sense
for the final patch.  I'd suggest making it a completely automatic
symbol with no title.

> >
> >>> +    def_bool n

You already say "bool" above, and "default n" is the default default, so
you can omit this line entirely.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/