Re: [Xen-devel] [PATCH] xen: fix sparse warning in p2m.c

From: David Vrabel
Date: Fri Dec 05 2014 - 05:43:19 EST


On 05/12/14 06:16, Juergen Gross wrote:
> The patch "Speed up set_phys_to_machine() by using read-only mappings"
> introduced a sparse warning:
>
> arch/x86/xen/p2m.c:628:13: sparse: incorrect type in argument 1
> (different address spaces)
>
> Avoid the warning.

Thanks.

But can you add some helper functions instead? Perhaps:

static inline int xen_safe_write_ulong(unsigned long *addr,
unsigned long val)
{
//...
}

static inline int xen_safe_read_ulong(unsigned long *addr,
unsigned long *val)
{
//...
}

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/