Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()

From: Dan Carpenter
Date: Fri Dec 05 2014 - 08:57:49 EST


On Fri, Dec 05, 2014 at 01:44:30PM +0100, SF Markus Elfring wrote:
> >> The data structure element "arc4" was assigned a null pointer by the
> >> mppe_alloc() function if a previous function call "crypto_alloc_blkcipher"
> >> failed.
> >
> > crypto_alloc_blkcipher() returns error pointers and not NULL.
>
> That is true.
>

Oh. In that case, I misunderstood what you wrote. Looking at it now,
this patch is actually ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/