Re: [PATCH] [PATCH] VERIFY_OCTAL_PERMISSIONS: Move to <linux/sysfs.h> where it belongs

[Andrew Morton]

On 5 Dec 2014 21:49:52 -0500 "George Spelvin" <linux@xxxxxxxxxxx> wrote:

> >> -----
> 
> > This shouldn't be here because "^---" is considered "end of changelog".
> 
> Damn it, I couldn't remember how to add not-for-commit comments to a patch.
> I RTFMed and thought that was what "git mailinfo --scissors" wanted.
> 
> (Normally, I put it down with the diffstat, but preferred a more
> prominent place for this conversation.)

I think in 100% of cases I find the stuff that people put below the
^--- was useful info, so I move it into the changelog.  Yours was no
exception ;) 

> > Let's include bug.h into sysfs.h.
> 
> It worked without, but yeah... since I can't figure *how* it works.

heh.  `KCPPFLAGS=-H make foo.o' will show the include graph.  I usually
do `make foo.i' then go poke around in foo.i to work out how foo.c
received a particular definition.

> >> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> >> index 1c9effa2..974097df 100644
> >> --- a/include/linux/moduleparam.h
> >> +++ b/include/linux/moduleparam.h
> >> @@ -1,9 +1,9 @@
> >>  #ifndef _LINUX_MODULE_PARAMS_H
> >>  #define _LINUX_MODULE_PARAMS_H
> >>  /* (C) Copyright 2001, 2002 Rusty Russell IBM Corporation */
> >> -#include <linux/init.h>
> >>  #include <linux/stringify.h>
> >> -#include <linux/kernel.h>
> >> +#include <linux/sysfs.h>
> >> +#include <linux/types.h>
> 
> > Removing the kernel.h inclusion is good, but risky.  Are you sure
> > there's nothing in moduleparam.h which uses kernel.h things?
> 
> Well, I did a quick eyeball-scan, then did my usual build, then
> an allyesconfig and an allmodconfig.
> 
> I found some other alarming things, but nothing related to this.
> 
> E.g.
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c: In function 'i40e_dbg_dump_desc':
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c:855:1: warning: the frame size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>  }
> 
> (Honestly, I didn't wait for the allmodconfig to finish, since I
> expected it to fail within the first few hundred modules if it was going to
> fail at all, but it has finished now.)

OK, let's run with it and see what happens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/