Re: [PATCH 1/4] iio: accel: kxcjk-1013: always power on device in resume

From: Jonathan Cameron
Date: Sat Dec 06 2014 - 06:15:54 EST


On 05/12/14 22:18, Irina Tirdea wrote:
> When the system resumes, it will first call system resume and
> then runtime suspend (if CONFIG_RUNTIME_PM is enabled).
> There is no need to conditionally power on the device in
> system resume, so always power it on and leave runtime
> suspend to power it off if needed.
>
> Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git

Thanks,
> ---
> drivers/iio/accel/kxcjk-1013.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 1720e9a..aed3777 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1354,10 +1354,7 @@ static int kxcjk1013_resume(struct device *dev)
> int ret = 0;
>
> mutex_lock(&data->mutex);
> - /* Check, if the suspend occured while active */
> - if (data->dready_trigger_on || data->motion_trigger_on ||
> - data->ev_enable_state)
> - ret = kxcjk1013_set_mode(data, OPERATION);
> + ret = kxcjk1013_set_mode(data, OPERATION);
> mutex_unlock(&data->mutex);
>
> return ret;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/